Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary dependencies #3139

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Removed unnecessary dependencies #3139

merged 1 commit into from
Jul 27, 2023

Conversation

hbelmiro
Copy link
Contributor

No description provided.

@hbelmiro
Removed unnecessary dependencies
7c59382 
Signed-off-by: Helber Belmiro <[email protected]>
@kie-ci3
Copy link
Contributor

kie-ci3 commented Jul 26, 2023

(tests) - kogito-runtimes job #2949 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

export BUILD_MVN_OPTS_CURRENT=-T 1C -Dvalidate-formatting -Prun-code-coverage
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/kogito-pipelines/main/.ci/pull-request-config.yaml' -o 'bc' -p kiegroup/kogito-runtimes -u https://github.com/kiegroup/kogito-runtimes/pull/3139 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-runtimes.tests.kogito-runtimes/2949/display/redirect

Test results:

  • PASSED: 3346
  • FAILED: 1

Those are the test failures:

org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testFindByIdReadMode
expected: 5
but was: 0

@hbelmiro hbelmiro marked this pull request as ready for review July 26, 2023 17:15
@hbelmiro
Copy link
Contributor Author

jenkins rerun kogito-runtimes tests

@kie-ci3
Copy link
Contributor

kie-ci3 commented Jul 26, 2023

(tests) - kogito-runtimes job #2950 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

export BUILD_MVN_OPTS_CURRENT=-T 1C -Dvalidate-formatting -Prun-code-coverage
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/kogito-pipelines/main/.ci/pull-request-config.yaml' -o 'bc' -p kiegroup/kogito-runtimes -u https://github.com/kiegroup/kogito-runtimes/pull/3139 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-runtimes.tests.kogito-runtimes/2950/display/redirect

Test results:

  • PASSED: 3346
  • FAILED: 1

Those are the test failures:

org.kie.kogito.it.KafkaPersistenceIT.testAsyncWIH Assertion condition defined as a lambda expression in org.kie.kogito.it.PersistenceTest that uses java.lang.String 1 expectation failed.
Expected status code <404> but was <200>.
within 10 seconds.

@hbelmiro
Copy link
Contributor Author

jenkins rerun kogito-runtimes tests

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hbelmiro hbelmiro requested a review from radtriste July 26, 2023 18:34
@radtriste radtriste merged commit 2f996e2 into apache:main Jul 27, 2023
11 of 12 checks passed
@hbelmiro hbelmiro deleted the remove-unecessary-deps branch July 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radtriste radtriste radtriste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbelmiro @kie-ci3 @radtriste